Skip to content

Conversation

@cvanelteren
Copy link
Collaborator

fixes #82

@cvanelteren cvanelteren marked this pull request as draft February 19, 2025 08:31
@cvanelteren
Copy link
Collaborator Author

Converting to draft to figure out why some are missing

@cvanelteren cvanelteren marked this pull request as ready for review February 19, 2025 09:40
@cvanelteren
Copy link
Collaborator Author

The colormap names are changed by the class _Colormap inside ultraplot's color. It seems to copy the name and append a "_" which the original proplot code checks for but then ignores. I converted the code to accept a dictionary and passing along the name that exists in the database. This seems to work, but the naming conversion still puzzles me and is a legacy artifact from proplot.

Copy link
Collaborator

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be picky on demo code here. We do need to make an issue about the color map names though.

LGTM!

@cvanelteren cvanelteren merged commit 6ff422e into Ultraplot:main Feb 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color Cycles Overview not rendered

2 participants